Support OAuth2 authentication

MarcialRosales commented 1 year ago

Fixes #956

Proposed Changes

Enable the following mechanisms via two attributes added to the ConnectionFactory:

Obtain Basic Credentials (this means username+password or Oauth2 tokens) via the interface ICredentialsProvider
In case of OAuth2 credentials, which they have a validity period, refresh the tokens before they expire.

This PR is accompanied by another PR on the rabbitmq-website to update the .Net Client guide.

Acceptance Tests

Via TestApplications/OAuth2, it is possible to test end-to-end the following flows:

Initial token request and connection establishment with the token (using standard connection)
refresh the token via the token request. This is tested with keycloak
refresh the token by requesting a new one. This is tested with uaa
Specify extra parameters to be included when requesting a token such as scope.

To do:

Test using TLS with the authorization server

Types of Changes

What types of changes does your code introduce to this project? Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes issue #NNNN)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause an observable behavior change in existing systems)
[ ] Documentation improvements (corrections, new content, etc)
[ ] Cosmetic change (whitespace, formatting, etc)

This PR is accompanied by another docs' PR

jonproch117 commented 1 year ago

Is this feature still planned to be released? The associated changes to the website here from this PR were published, which threw me off since the referenced classes/properties don't yet exist in the library.

Thanks!

lukebakken commented 1 year ago

@jonproch117 - I'm working on reviewing this PR now. I should be able to get it released by the end of August. Sorry about the confusion!

MarcialRosales commented 1 year ago

Excellent @lukebakken ! Good call on splitting that dependency. We just need to make it clear in the documentation to include this extra DLL when using OAuth2 authentication/authorization. Shall I create that doc's PR or will you do it?

lukebakken commented 1 year ago

We just need to make it clear in the documentation to include this extra DLL when using OAuth2 authentication/authorization. Shall I create that doc's PR or will you do it?

Go right ahead. I think it should be pretty clear to end-users but best to make it as obvious as possible.

lukebakken commented 1 year ago

@jonproch117 - if you'd like to test this out, please see the following beta releases:

I'm working on documentation at this time. You can see an example of how to use the new library via our test code here:

https://github.com/rabbitmq/rabbitmq-dotnet-client/tree/6.x/projects/TestApplications/OAuth2

jonproch117 commented 1 year ago

@lukebakken This is working for me. Thanks!

lukebakken commented 12 months ago

@jonproch117 thank you! I will release version 6.6.0 today.

rabbitmq / rabbitmq-dotnet-client