7.0 release checklist / misc items

[lukebakken]

• [ ] Update CHANGELOG.md
• [x] Update copyright headers (https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1589)
• [x] Use newer C# language features
  • readonly fields instead of get;
  • TODO
• [x] Consider immutable collections, and / or make as many object immutable via language features as possible. See @danielmarbach's comment here
• [x] Address TODO comments in the code
• [ ] Expose public implementation of ITcpClient or come up with a better way of setting socket options. See #1415 and this discussion. Note: TcpClientAdapter was made public in https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1417
• [ ] Ensure documentation XML is accurate
• [x] Remove deprecated API methods and other entities. API should be async-only.
• [x] Replace var with explicit types when appropriate.
• [x] Investigate "bypassing" await when IsCompletedSuccessfully is true (though, frankly, I prefer easier-to-read code 😸). These appear to be relevant:
  • https://github.com/dotnet/runtime/issues/11803
  • https://github.com/dotnet/runtime/issues/11803#issuecomment-454095097
  • https://blog.stephencleary.com/2016/12/eliding-async-await.html
• [x] Do not "elide" async/await when exceptions must be caught (@danielmarbach's noticed that here)
• [x] See if exception handling code can be simplified (see @Tornhoof's comment)
• [x] Ensure convenience methods like QueueDeclarePassive have async versions.

[lukebakken]

@stebet what do you think of this item?

Mark all sync API methods as Obsolete. Version 8 of this lib could then be async-only.

[stebet]

@stebet what do you think of this item?

Mark all sync API methods as Obsolete. Version 8 of this lib could then be async-only.

All for it!

[bangjiehan]

Does we need QueueDeclarePassiveAsync too?

[lukebakken]

@bangjiehan -

Does we need QueueDeclarePassiveAsync too?

The QueueDeclareAsync method has a passive parameter. Set it to true, and you will do a passive declaration.

QueueDeclarePassive has always been a convenience method added to the API. I'll make a note to add it to version 7.

[lukebakken]

https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1589

[Gladskih]

Is there documentation for new API? Or at least some example.

[lukebakken]

@Gladskih there isn't too much of a difference between the old API and the new one, to be honest. If you need a reference, the best place at this time are the test applications and integration tests:

• https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/main/projects/Test/Applications/MassPublish/Program.cs
• https://github.com/rabbitmq/rabbitmq-dotnet-client/tree/main/projects/Test/Integration

If you need further assistance, please start a discussion rather than commenting on an issue: https://github.com/rabbitmq/rabbitmq-dotnet-client/discussions

[lukebakken]

@bollhals just FYI, I have decided that version 7 should ship on July 12th. I'm releasing 7.0.0-rc.2 today.