Remove the in modifier from async methods.
Mentioned the management plugin in the test documentation.
Closes #1601
Types of Changes
What types of changes does your code introduce to this project?
Put an x in the boxes that apply
[x] Bug fix (non-breaking change which fixes issue #NNNN)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause an observable behavior change in existing systems)
[x] Documentation improvements (corrections, new content, etc)
[ ] Cosmetic change (whitespace, formatting, etc)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories
Further Comments
Some tests in SequentialIntegration fail locally with timeouts, e.g. Test.SequentialIntegration.TestConnectionRecovery.TestShutdownEventHandlersRecoveryOnConnectionAfterDelayedServerRestart [FAIL], the tests all time out.
These fail with the main branch too on my system, this does not appear to be related. Not sure what's wrong there.
I added a short addendum to the RUNNING_TESTS.md that it requires the management plugin, which is not strictly part of the default package, it needs to be enabled (at least on windows).
Proposed Changes
Remove the
inmodifier from async methods. Mentioned the management plugin in the test documentation. Closes #1601Types of Changes
What types of changes does your code introduce to this project? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CONTRIBUTING.mddocumentFurther Comments
Some tests in SequentialIntegration fail locally with timeouts, e.g.
Test.SequentialIntegration.TestConnectionRecovery.TestShutdownEventHandlersRecoveryOnConnectionAfterDelayedServerRestart [FAIL], the tests all time out. These fail with the main branch too on my system, this does not appear to be related. Not sure what's wrong there.I added a short addendum to the RUNNING_TESTS.md that it requires the management plugin, which is not strictly part of the default package, it needs to be enabled (at least on windows).