change InboundFrame to a class

bollhals commented 1 week ago

Proposed Changes

Changes the InboundFrame to a class instead of a readonly struct. There's only ever one frame active per connection, hence it can be a class that is allocated once and then reused.

benefits

Simplifies handling of the type, as classes are easier to handle than struct (e.g. avoid struct copies, async incompatibilities around in).
Most likely improves performance very slightly, but unable to provide evidence, as it's within the error margin.
Simplifies handling of the rented memory, as the array can now be nulled out

Types of Changes

[ ] Bug fix (non-breaking change which fixes issue #NNNN)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause an observable behavior change in existing systems)
[ ] Documentation improvements (corrections, new content, etc)
[ ] Cosmetic change (whitespace, formatting, etc)
[x] Performance / Simplification change

Checklist

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x] All tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories

Further Comments

There's a bugfix in here as well, if wanted, I can submit that separately. see my comments.

lukebakken commented 1 week ago

@bollhals I converted this PR to a draft. Feel free to click "Ready for review" when you're done.

Thank you for this contribution!

bollhals commented 1 week ago

@bollhals I converted this PR to a draft. Feel free to click "Ready for review" when you're done.

Thank you for this contribution!

It's ready. It was just some whitespace formatting issue. (My settings are different than what's expected here)

stebet commented 6 days ago

Nice!

bollhals commented 6 days ago

Thank you! I will merge once CI passes and will release RC.3

Just FYI, I have currently a bit of spare time (again after some busy years^^) and plan to push a few updates. (Up to you to include it them in whatever version you see fit 👍 (Another RC or 7.x or even 8))

lukebakken commented 6 days ago

@bollhals thank you, I will keep an eye out. I would like to get version 7 released soon but am happy to wait on your contributions.

rabbitmq / rabbitmq-dotnet-client