Avoid boxing in IEndpointResolverExtensions.cs - Githubissues

rabbitmq / rabbitmq-dotnet-client

RabbitMQ .NET client for .NET Standard 2.0+ and .NET 4.6.2+

https://www.rabbitmq.com/dotnet.html

Other

2.05k stars 575 forks source link

Avoid boxing in IEndpointResolverExtensions.cs #1619

Closed lechu445 closed 4 days ago

lechu445 commented 5 days ago

Proposed Changes

Technically T can be a value type. Object.Equals has an overload that takes object therefore any struct would be boxed. To avoid it, EqualityComparer<T>.Default.Equals should be used.

Types of Changes

[x] Bug fix (non-breaking change which fixes issue #NNNN)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause an observable behavior change in existing systems)
[ ] Documentation improvements (corrections, new content, etc)
[ ] Cosmetic change (whitespace, formatting, etc)

Checklist

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x] All tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories

Further Comments