search

rabbitmq / rabbitmq-erlang-client

Erlang client for RabbitMQ
https://www.rabbitmq.com/
Other
184 stars 127 forks source link

Random Queue of rpc_client house keeping #6

Closed witeman closed 10 years ago

witeman commented 10 years ago

...uld be left after rpc client ended. So declaring it into a auto-delete queue would be much better.

witeman commented 10 years ago

rpc client would create a random name queue every time, but the queue would be left after rpc client ended. So declaring it into a auto-delete queue would be much better.

michaelklishin commented 10 years ago

I'd argue it then should be exclusive, too (the only allowed users is the creating connection, plus guaranteed to be deleted after connection closure).

witeman commented 10 years ago

Yes, exclusive added is much better.

michaelklishin commented 10 years ago

This repository is a mirror. We'll apply your patch to the mainline Mercurial repo (and give you credit in the commit message, of course) and see if all team members agree this is the right thing to do. Thank you for contributing.

michaelklishin commented 10 years ago

I've found a bug in our tracker that suggests the attributes should be configurable instead of hardcoded. I think we'll do this, and use the parameters in your patch as the defaults.