pass connection_timeout to the SSL upgrade

rabbitmq / rabbitmq-erlang-client

Erlang client for RabbitMQ

https://www.rabbitmq.com/

Other

184 stars 127 forks source link

pass connection_timeout to the SSL upgrade #65

Closed cooper6581 closed 8 years ago

michaelklishin commented 8 years ago

Can you please submit this against the stable branch?

michaelklishin commented 8 years ago

@cooper6581 don't worry about it, I will cherry-pick. Thank you!

cooper6581 commented 8 years ago

Sorry about that, I got scared. Thanks @michaelklishin!!

michaelklishin commented 8 years ago

Done.

michaelklishin commented 8 years ago

Note: this passes the timeout value as is. We should make sure that Federation and Shovel, which accept timeouts in seconds, perform the conversion. This client is used directly as well.

cooper6581 commented 8 years ago

I tested Federation. The values end up coming in as milliseconds. With the URI of amqps://admin:admin@dev76-dkoupal-rmq02?heartbeat=5&connection_timeout=300 Timeout will end up getting 300. I'll try and test with Shovel later today.