rabbitmq / rabbitmq-erlang-client

Erlang client for RabbitMQ
https://www.rabbitmq.com/
Other
184 stars 127 forks source link

rabbitmq-erlang-client should define deps of syntax_tools and compiler #72

Closed simonxuhao closed 7 years ago

simonxuhao commented 7 years ago

with amqp_client in DEPS, release built by erlang.mk can't start:

{{function_clause,[{amqp_gen_connection,terminate,[{undef,[{erl_syntax,form_list,[[{attribute,1,file,{"src/time_compat.erl",1}},...

after adding syntax_tools into LOCAL_DEPS:

{{function_clause,[{amqp_gen_connection,terminate,[{undef,[{compile,forms,[[{attribute,1,file,{"src/time_compat.erl",1}},...

adding compiler into LOCAL_DEPS and it works

essen commented 7 years ago

PR ready to review and merge.

michaelklishin commented 7 years ago

Thank you, @nestor5 and @essen.

michaelklishin commented 7 years ago

FTR, we had to do https://github.com/rabbitmq/rabbitmq-erlang-client/commit/712f7b341b3aac20f8fdbb23fd960aea4d0f1f0f as well.