search

rabbitmq / rabbitmq-erlang-client

Erlang client for RabbitMQ
https://www.rabbitmq.com/
Other
184 stars 127 forks source link

Enable hostname verification for OTP 19 #95

Closed lukebakken closed 6 years ago

lukebakken commented 6 years ago

[153560059]

Ensure that verify_fun and server_name_indication are added to .config params, too Fix issue with module for verify_fun

PR rabbitmq/rabbitmq-ct-helpers#17 isn't strictly necessary for this, but related.

michaelklishin commented 6 years ago

I'm getting two failures on 20.x and 20.1:

system_SUITE > network_connection_tests > parallel_tests > basic_get_ipv6_ssl
    #1. {error,{{case_clause,{error,{tls_alert,"handshake failure"}}},
                [{system_SUITE,basic_get,1,
                               [{file,"test/system_SUITE.erl"},{line,271}]},
                 {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1539}]},
                 {test_server,run_test_case_eval1,6,
                              [{file,"test_server.erl"},{line,1055}]},
                 {test_server,run_test_case_eval,9,
                              [{file,"test_server.erl"},{line,987}]}]}}

system_SUITE > network_connection_tests > parallel_tests > basic_get_ipv4_ssl
    #1. {error,{{case_clause,{error,{tls_alert,"handshake failure"}}},
                [{system_SUITE,basic_get,1,
                               [{file,"test/system_SUITE.erl"},{line,271}]},
                 {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1539}]},
                 {test_server,run_test_case_eval1,6,
                              [{file,"test_server.erl"},{line,1055}]},
                 {test_server,run_test_case_eval,9,
                              [{file,"test_server.erl"},{line,987}]}]}}
michaelklishin commented 6 years ago

Note: on MacOS this should be tested in conjunction with https://github.com/rabbitmq/rabbitmq-ct-helpers/commit/426a61b0bc67bd21a221785394262d7f3ab0c893.