rabbitmq / rabbitmq-federation

RabbitMQ Federation plugin
https://www.rabbitmq.com/
Other
40 stars 21 forks source link

Change algorithm for federation link ID generation from term_to_binary to phash2. #58

Closed hairyhum closed 7 years ago

hairyhum commented 7 years ago

Part of rabbitmq/rabbitmq-server#1243

term_to_binary can change in defferent OTP versions. Using phash2 to generate hashes should be more portable. The hash will be used in federation status output and federation management UI. The ID is saved in ETS, so it should be safe to change it during upgrade.

michaelklishin commented 7 years ago

Note: this change should be backwards compatible in practice because link IDs are transient state that changes between plugin (or node) restarts anyway.