search

rabbitmq / rabbitmq-federation

RabbitMQ Federation plugin
https://www.rabbitmq.com/
Other
40 stars 21 forks source link

Consumer tag with queue federation #66

Closed uvzubovs closed 5 years ago

uvzubovs commented 6 years ago

When federating queues, downstream creates a consumer on the upstream queue with tag "consumer". This seems to be too terse. Would it be possible to name this consumer somewhat more eloquently, e.g. after the downstream? Would consumer tags collide when there is more than one downstream? Thanks

RabbitMQ 3.6.12, Erlang 19.3.6.2

hairyhum commented 5 years ago

Consumer tags are scoped by channel, so there should not be any issues with having the same consumer tag on different channels for the same queue. Technically threre is no such thing as downstream "name", there is only IP, which is already available in the channel info. But surely a name like "federation-" would be still more representative. Or maybe federated queue settings may include consifurable consumer name field for operators to use.

Sorry for the late reply. We're doing some old story digging.

michaelklishin commented 5 years ago

Note that the PRs that add support of user-provided tags are currently set for 3.8.0.