Fix direct connections not closing

ricardobcl commented 6 years ago

This PR attempts to fix issue #76 .

Proposed Changes

Two changes:

When terminating the federation exchange link, first close the direct connection;
When calling the disposable_channel_call/2/3, don't assume that connection is up.

[x] Bugfix (non-breaking change which fixes issue #76)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance)

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x] All tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in related repositories

pivotal-issuemaster commented 6 years ago

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 6 years ago

@ricardobcl Thank you for signing the Contributor License Agreement!

michaelklishin commented 6 years ago

I can confirm that the fix is effective. Thank you for the excellent contribution, @ricardobcl!