Not really on the critical path, but speed of link initialisation can be improved here, shared downstream and upstream connection names should only be acquired/computed once, and used for both (considering the possibility of high rate of link adjustments and restarts per policy/parameters definition change, or, network instability, which eventually has direct impact on top level supervisor as well, especially with the increase in magnitude of links count).
The rabbit_federation_util:name/1 resource name conversion also made more explicit. Applies to both exchange and queue resources, and is used by both link types (but currently coming across as applying to exchange resources only).
Types of Changes
[x] Bugfix (non-breaking change which fixes issue #NNNN)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
michaelklishin
commented
6 years ago
Proposed Changes
Not really on the critical path, but speed of link initialisation can be improved here, shared downstream and upstream connection names should only be acquired/computed once, and used for both (considering the possibility of high rate of link adjustments and restarts per policy/parameters definition change, or, network instability, which eventually has direct impact on top level supervisor as well, especially with the increase in magnitude of links count).
The
rabbit_federation_util:name/1resource name conversion also made more explicit. Applies to both exchange and queue resources, and is used by both link types (but currently coming across as applying to exchange resources only).Types of Changes
Checklist
CONTRIBUTING.mddocument