Change federation consumer name from "consumer" to "federation-link-<upstream_name>".

hairyhum commented 5 years ago

Proposed Changes

This would make it easier to distinguish federation links from other consumers and from each other (if configured with different names)

Adresses #66 in a way

Types of Changes

What types of changes does your code introduce to this project? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes issue #66 )
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask on the mailing list. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x] All tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories

hairyhum commented 5 years ago

This may be backported to 3.7. People should not rely on consumer tag, technically.

michaelklishin commented 5 years ago

Backported to v3.7.x.

rabbitmq / rabbitmq-federation