rabbitmq / rabbitmq-management

RabbitMQ Management UI and HTTP API
https://www.rabbitmq.com/management.html
Other
370 stars 165 forks source link

Respond with a Bad Request when client provides double-encoded JSON #848

Closed michaelklishin closed 3 years ago

michaelklishin commented 3 years ago

instead of a 500.

@lukebakken I would understand if addressing this would be considered to be "too much" but looks like it's a pretty safe and minor change.

To run a focussed test:

gmake ct-rabbit_mgmt_only_http t="all_tests_without_prefix:double_encoded_json_test"

Closes #839.

lukebakken commented 3 years ago

I'm planning to test and review this today!

michaelklishin commented 3 years ago

Backported to v3.8.x.