Downgrade QoS 2 to QoS 1 when sending Last Will - Githubissues

rabbitmq / rabbitmq-mqtt

RabbitMQ MQTT plugin

https://www.rabbitmq.com/mqtt.html

Other

174 stars 67 forks source link

Downgrade QoS 2 to QoS 1 when sending Last Will #215

Closed michaelklishin closed 4 years ago

michaelklishin commented 4 years ago

Proposed Changes

QoS 2 was not downgraded to QoS 1 correctly when Last Will messages were sent.

Types of Changes

[x] Bugfix (non-breaking change which fixes issue #214)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance)

Checklist

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x] All tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in related repositories

Further Comments

Closes #214.

michaelklishin commented 4 years ago

Backported to v3.8.x and v3.7.x.