cache topic translation results - Githubissues

rabbitmq / rabbitmq-mqtt

RabbitMQ MQTT plugin

https://www.rabbitmq.com/mqtt.html

Other

174 stars 67 forks source link

cache topic translation results #216

Closed velimir closed 4 years ago

velimir commented 4 years ago

Proposed Changes

Cache topic translation for performance optimisation

Types of Changes

[x] Bugfix (non-breaking change which fixes issue #NNNN)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance)

Checklist

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[ ] All tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories

Further Comments

Original performance

channel - original

connection - original

1 topic (cache-only)

channel - convert 1 topic (cache only)

connection - convert 1 topic (cache only)

30 topics (always miss/worst case)

channel - convert 30 topics (cache-not-used)

connection - convert 30 topics (cache-not-used)

Search in full cache (12 topics)

channel - convert cache full

connection - convert cache full

michaelklishin commented 4 years ago

That's a non-trivial gain, thank you!