search

rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Change deployment target to 10.9 #126

Closed afedor closed 6 years ago

afedor commented 6 years ago

It would be super helpful to change the deployment target to 10.9 instead of 10.11 so this can be used more widely in other projects. It isn't likely that a lot of people use 10.9, but there don't seem to be any reasons not to support it

michaelklishin commented 6 years ago

Thanks. We can do this. I hope to port this client entirely to Swift in the future but growing convinced it should be a separate project, so that this client lives on in bug fix only mode.

afedor commented 6 years ago

Sounds good to me

michaelklishin commented 6 years ago

I don't know what's going on with Travis' PR test, will test locally later today.

michaelklishin commented 6 years ago

Unfortunately this would require giving up some Swift features:

▸ Compiling ConnectionHelper.swift

Testing failed:
    'global(qos:)' is only available on OS X 10.10 or newer
    'utility' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'userInteractive' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'background' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'utility' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'userInteractive' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'background' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'default' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'userInteractive' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'default' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'background' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'userInteractive' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'utility' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'background' is only available on OS X 10.10 or newer
    'global(qos:)' is only available on OS X 10.10 or newer
    'userInteractive' is only available on OS X 10.10 or newer
** TEST FAILED **

@afedor I assume it is easy enough to override this target. If not, I'm all for introducing a way to override it on a per-environment basis.

afedor commented 6 years ago

I'm using Carthage, which doesn't have a way to change options, but it is easy enough to change it by hand.