search

rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Fix Close Connection Deadlock #137

Closed tonyli508 closed 6 years ago

tonyli508 commented 6 years ago

Fixing issue #112. Thx @vberezkin for the test case.

pivotal-issuemaster commented 6 years ago

@tonyli508 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 6 years ago

@tonyli508 Thank you for signing the Contributor License Agreement!

michaelklishin commented 6 years ago

Thank you. I'm on PTO this week but will try to find a time slot to QA this.

michaelklishin commented 6 years ago

I'm having some build toolchain issues on a new-ish machine, not yet ready to really QA this. Sorry.

michaelklishin commented 6 years ago

I'm having issues running the tests, more specifically I run into a segfault:

Segmentation fault: 11 xcodebuild test -project RMQClient.xcodeproj -scheme RMQClient -destination 'platform=iOS Simulator,name=iPhone SE,OS=11.3'

will try to upgrade all dependencies there and try cleaning/different platform versions next.

michaelklishin commented 6 years ago

I will merge a separate branch that has some wording and license header changes. Thank you!