search

rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Bump version number for Cocoapods and Carthage #148

Closed mattbradbury closed 5 years ago

mattbradbury commented 5 years ago

Master branch builds for OSX just fine with both Cocoa and Carthage, just needs a little admin love with the version numbers and tags

michaelklishin commented 5 years ago

What problem would that solve?

mattbradbury commented 5 years ago

I can build by using git commands in the carthage file. Carthage and Cocoapods need to use the git release tags to properly download the current releases

michaelklishin commented 5 years ago

So you are asking for a new release?

michaelklishin commented 5 years ago

Carthage can use Git commits, e.g.

github "rabbitmq/rabbitmq-objc-client" "master"

should work.

A new release will be out once #146 is addressed.

michaelklishin commented 5 years ago

I think we are ready to produce a new release.

grsteffens commented 5 years ago

Any update or ETA on this? I tried pulling in the latest changes by pointing my Cocoapods spec to the master branch, however it appears now conforming to the RMQConnectionDelegate causes a linker issue? If I remove my implementation of this delegate's methods, all is well again.

michaelklishin commented 5 years ago

I can look into it in the next couple of days.

michaelklishin commented 5 years ago

I cannot comment on "a linker issue". This issue is about producing a new release. That said, I think we should produce an RC first and try it out e.g. with rabbitmq/rabbitmq-tutorials.

michaelklishin commented 5 years ago

I experimented with this today in hopes to produce an RC. Unfortunately I cannot finish this today and won't be around tomorrow but this is my priority number one for Friday.

michaelklishin commented 5 years ago

I found a bug in client-initiated connection.close handling that got revealed by a Swift 5 upgrade. Will produce an RC1 after fixing it.

grsteffens commented 5 years ago

Hi @michaelklishin, any update on the RC1?

michaelklishin commented 5 years ago

I'm fighting pod trunk push, looks like the only outstanding issue is that my user doesn't have the permissions. I've contacted the original author and trying to sign in using our team account.

michaelklishin commented 5 years ago

Looks like we will have to go through the pod dispute/claim process to regain push permissions :(

michaelklishin commented 5 years ago

0.11.0-rc1 is up on cocoapods.org.

michaelklishin commented 5 years ago

See #166 for GA release. We only need some feedback, tutorial updates and a change log. @grsteffens your feedback would be most welcome :)

grsteffens commented 5 years ago

Implementing now, I will follow up on #166 with my feedback. Thanks @michaelklishin !