search

rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Adjust project settings to allow building with Carthage #151

Closed simba909 closed 5 years ago

simba909 commented 5 years ago

This fixes an issue when building with Carthage. Specifically, when building the master branch it tries to build for the armv7s architecture - which is not supported by the dependecies - and that then leads to a build failure. With this PR I fixed the issue by simply reverting the ARCH-settings to their default values.

It might be that the ARCH values need to hard-coded for some use-cases, but I didn't run into any issues. Please let me know if I missed something or if there's a better solution to this 👍

pivotal-issuemaster commented 5 years ago

@simba909 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 5 years ago

@simba909 Thank you for signing the Contributor License Agreement!

michaelklishin commented 5 years ago

The list of architectures was an attempt to fix an annoying warning XCode produces. No objections to using the default list.

michaelklishin commented 5 years ago

Thank you!