search

rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Provide a way to set a user-provided connection name #155

Closed michaelklishin closed 5 years ago

michaelklishin commented 5 years ago

Started as a question in #154.

This client currently hardcodes client_properties and so there is no way to provide a user-specific connection name or any other property. Ideally there should be a connection factory field for the name and a dictionary that would be merged with a set of predefined fields in addition to that.

michaelklishin commented 5 years ago

@grsteffens I'm afraid I cannot assign this issue to someone who isn't a collaborator on this repo. While I can add you it may be overkill for a single change. In any case, I am happy to get it very soon. You can help by giving the new API elements a shot :)

grsteffens commented 5 years ago

@michaelklishin understood. I really just needed this as soon as possible due to an implementation I am working on and wanted to offer my assistance as to help expedite the enhancement. Just so I have an idea, what would the timeline look like for another established collaborator to complete this task?

p.s - Regarding the new API elements, where can those be found?

Thanks!

michaelklishin commented 5 years ago

@grsteffens in a pull request I am yet to submit. It should be done by tomorrow.

Now that you can run the tests in the RMQClient scheme against any RabbitMQ node (no need to preconfigure), it should take less than an hour. If you can't wait until tomorrow, feel free to look into it. Otherwise I'm happy to do it.

grsteffens commented 5 years ago

@michaelklishin that is awesome. I appreciate the quick turnaround on this. Let me know if there is anything I can do to assist.