search

rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Release 0.11.0 GA #166

Closed michaelklishin closed 4 years ago

michaelklishin commented 5 years ago

Follow-up to #148.

grsteffens commented 5 years ago

@michaelklishin is there an eta on an official release of 0.11.0?

michaelklishin commented 5 years ago

I haven't seen much feedback in https://github.com/rabbitmq/rabbitmq-objc-client/issues/148. There was one change after rc.1. If it works well I see no reason to delay the release..

timhonders commented 4 years ago

@michaelklishin is there an eta on an official release of 0.11.0?

michaelklishin commented 4 years ago

We haven't seen much feedback in #148 or otherwise. Does it work well for your project @timhonders?

timhonders commented 4 years ago

@michaelklishin The library works well, but we have a problem installing.

We have a pod plugin that uses RMQClient as dependency, when i set

s.dependency 'RMQClient' pod install installs version 0.10.0, but oure plugin uses 0.11.0-rc1.

Fixed it by adding

pod 'RMQClient', :git => 'https://github.com/rabbitmq/rabbitmq-objc-client.git'

to the pod file

And removing the dependency

michaelklishin commented 4 years ago

Thanks. I'll look into publishing a pod release.

timhonders commented 4 years ago

thnx

Grimal commented 4 years ago

Was 0.11.0 GA ever published? The page on CocoaPods.org and a generic pod 'RMQClient' and pod install pulls down 0.10.0

michaelklishin commented 4 years ago

Apparently not.

On Wed, Apr 29, 2020 at 11:25 PM Brian Grimal notifications@github.com wrote:

Was 0.11.0 GA ever published? The page on CocoaPods.org and a generic pod 'RMQClient' and pod install pulls down 0.10.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rabbitmq/rabbitmq-objc-client/issues/166#issuecomment-621443655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAIQWVRL7ZM2HT664CIPDRPCEL5ANCNFSM4HGU64RQ .

-- MK

Staff Software Engineer, Pivotal/RabbitMQ

michaelklishin commented 4 years ago

0.11.0-rc2 is published to CocoaPods trunk. Please give it a shot. Unfortunately I have warnings after upgrading macOS and XCode, so I am worried this may have some kind of functional effects:

 -> RMQClient (0.11.0-rc2)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'JKVValue' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'CocoaAsyncSocket' from project 'Pods')
    - NOTE  | xcodebuild:  warning: User-supplied CFBundleIdentifier value 'io.pivotal.RMQClient' in the Info.plist must be the same as the PRODUCT_BUNDLE_IDENTIFIER build setting value 'org.cocoapods.RMQClient'. (in target 'RMQClient' from project 'Pods')
    - WARN  | [iOS] xcodebuild:  RMQClient/RMQClient/RMQGCDSerialQueue.m:108:13: warning: 'OSAtomicCompareAndSwap32' is deprecated: first deprecated in iOS 10.0 - Use atomic_compare_exchange_strong_explicit(memory_order_relaxed) from <stdatomic.h> instead [-Wdeprecated-declarations]
    - NOTE  | xcodebuild:  /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.4.sdk/usr/include/libkern/OSAtomicDeprecated.h:502:9: note: 'OSAtomicCompareAndSwap32' has been explicitly marked deprecated here
    - WARN  | [iOS] xcodebuild:  RMQClient/RMQClient/RMQGCDSerialQueue.m:122:13: warning: 'OSAtomicCompareAndSwap32' is deprecated: first deprecated in iOS 10.0 - Use atomic_compare_exchange_strong_explicit(memory_order_relaxed) from <stdatomic.h> instead [-Wdeprecated-declarations]
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'RMQClient' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'Pods-App' from project 'Pods')
    - NOTE  | xcodebuild:  note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted" (in target 'App' from project 'App')

but if someone can confirm the release can be consumed in macOS and iOS builds, I'll cut a GA release.

Grimal commented 4 years ago

Installed fine from CocoaPods.

Bundle identifier warning is a simple enough fix. I'm not getting the other compiler warnings with Xcode 11.4.1 (11E503a) and an OSX project though, haven't tried an iOS project yet.

michaelklishin commented 4 years ago

@Grimal if you could try an iOS one that would be really appreciated. If you know what the identifier issue is, let me know what should be done or go ahead and submit a PR. Thank you very much!

michaelklishin commented 4 years ago

Our tutorials use iOS simulator and work fine with 0.11.0-rc.2 so I'll proceed with producing a GA release tomorrow.

michaelklishin commented 4 years ago

An XCode update installed earlier today so I probably should redo my testing before releasing. Sorry.

michaelklishin commented 4 years ago

0.11.0 GA is up in CocoaPods trunk.