rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 85 forks source link

Add nullability annotations for RMQTLSOptions class #67

Closed sasikiran closed 8 years ago

sasikiran commented 8 years ago

In the following statement,

RMQTLSOptions *tlsOptions = [RMQTLSOptions fromURI:urlString verifyPeer:NO];

the urlString was accidentally nil and the app crashed. When I checked the code, I found that the class has missing nullability annotations. So, I added these.

camelpunch commented 8 years ago

Thanks for this. Could you please add a test to reproduce the issue? I can help or do this for you if the tests are a bit daunting.

camelpunch commented 8 years ago

Apologies, that comment ignored the fact that this is a compile-time change. Thanks for this!

sasikiran commented 8 years ago

You are right. It's a compiler level feature and hence I couldn't write a test. Thank you.