rabbitmq / rabbitmq-objc-client

RabbitMQ client for Objective-C and Swift
https://rabbitmq.com
Other
241 stars 84 forks source link

Wrap @import statements into precompiler condition #95

Closed ggiraudon closed 7 years ago

ggiraudon commented 7 years ago

Wrap @import statements into precompiler condition to avoid build problems when modules are disabled.

michaelklishin commented 7 years ago

This breaks CI :/

ggiraudon commented 7 years ago

Hi Micheal,

I'm not sure the patch itself breaks CI. The CI log hints at a git issue more than anything else. The error seems to be :

The command "git -C /usr/local/Library/Taps/homebrew/homebrew-core checkout 14aa94dd Formula/erlang.rb" failed and exited with 128 during .

which looks like something triggered by the test script itself.

Any chance you can take a look ?

michaelklishin commented 7 years ago

I restarted the build, lets see if the failure was transient.

michaelklishin commented 7 years ago

Right, so something is not right in the Travis environment :(

camelpunch commented 7 years ago

We were using a now-broken method of pinning a version of a package in Homebrew, as 3.6.3 got packaged into Homebrew even though it didn't work with Erlang 19. I've removed that broken pinning technique as 3.6.4 is now available.

If that works on master, please rebase or merge to trigger CI with that change.

camelpunch commented 7 years ago

@ggiraudon Master is now green after that change - please rebase.

ggiraudon commented 7 years ago

Sorry... feel a bit lost here... did you mean you want me to rebase to master and then reapply my patch ? I dont think my 2 trivial contributions have any impact on CI. This pull request should still merge fine against the current master, shouldnt it ? Let me know if there's anything you'd like me to do.

michaelklishin commented 7 years ago

@ggiraudon rebase your branch and push it. That will update this PR.

michaelklishin commented 7 years ago

Merged master in and re-submitted as #96.

michaelklishin commented 7 years ago

96 is in. Thank you, @ggiraudon!