search

rabbitmq / rabbitmq-prometheus

A minimalistic Prometheus exporter of core RabbitMQ metrics
Other
147 stars 110 forks source link

change regex for node/color labelling scheme in grafana dashboards #34

Closed Aakcht closed 4 years ago

Aakcht commented 4 years ago

Changed the regex for node/color labelling scheme in grafana dashboards (for zero node the change was from ^rabbit@\w+0 to ^rabbit@[\w.-]+0) . With this change RabbitMQ nodes with names like rabbit@rabbit-1.mycluster.mynamespace have correct colors in the dashboards. This makes node/color labelling work correctly in the deployments with similar naming scheme as is used in RabbitMQ K8S example .

closes #33

gerhard commented 4 years ago

This looks good, thanks for the contribution!

I will check tomorrow if make overview metrics still looks right before merging, back-porting to 3.8.x & updating at https://grafana.com/orgs/rabbitmq

👍🏻

gerhard commented 4 years ago

Marking it as draft so that it doesn't get merged by accident 👨‍💻

Aakcht commented 4 years ago

Hello, @gerhard, any updates?

gerhard commented 4 years ago

Will look at this today 👍

gerhard commented 4 years ago

Thanks @Aakcht! https://grafana.com/orgs/rabbitmq is now updated as well.

michaelklishin commented 4 years ago

Backported to v3.8.x.