search

rabbitmq / rabbitmq-prometheus

A minimalistic Prometheus exporter of core RabbitMQ metrics
Other
145 stars 109 forks source link

Metrics missing for distribution buffer busy limit - zdbbl #39

Closed gerhard closed 4 years ago

gerhard commented 4 years ago

Now that https://github.com/erlang/otp/pull/2270 & https://github.com/deadtrickster/prometheus.erl/pull/94 have been merged and released, we want to expose and visualise the distribution buffer busy limit (a.k.a. zdbbl).

The goal is to be able to measure how busy a particular distribution link is, so that users of RabbitMQ would know when increasing the inter-node communication buffer size would be beneficial. When implemented, this feature will be a good companion to RabbitMQ Runtime Tuning - Inter-node Communication Buffer Size.

This was created part of https://github.com/rabbitmq/tgir/pull/9. The expectation is that one of the viewers will implement this feature, by following the video. Hopefully, this will inspire others to contribute features & fixes to RabbitMQ 🙌🏻

Thanks Matt E for reminding us about this outstanding issue

michaelklishin commented 4 years ago

Everything is now in place to work on this.

gerhard commented 4 years ago

This actually shipped in 3.8.4. I was hoping that someone watching TGIR S01E04 will contribute it, but didn't want to keep it away from the users that were expecting it, so I shipped it darkly: https://github.com/rabbitmq/rabbitmq-prometheus/commit/17853e35ad114ee3791cdcd1646845a5da370d86

Will close this via PR that adds tests next & back-port to v3.8.x