search

rabbitmq / rabbitmq-prometheus

A minimalistic Prometheus exporter of core RabbitMQ metrics
Other
145 stars 109 forks source link

Add cluster label to metrics #41

Closed aitorpazos closed 4 years ago

aitorpazos commented 4 years ago

When you may be running multiple rabbitmq clusters in the same environment in combination with prometheus service discovery mechanisms it become necessary to differentiate the metrics belonging to multiple clusters.

Doing it as https://github.com/kbudde/rabbitmq_exporter does, this is, exposing the cluster name as a label would be enough.

gerhard commented 4 years ago

This is a Prometheus anti-pattern

It felt awkward to me first, but I eventually understood & accepted the reasoning behind it. Context: https://github.com/prometheus/docs/pull/1414#issuecomment-520505757

Related to https://github.com/rabbitmq/rabbitmq-prometheus/issues/50#issuecomment-648880995