rabbitmq / rabbitmq-prometheus

A minimalistic Prometheus exporter of core RabbitMQ metrics
Other
145 stars 109 forks source link

Convert all time metrics to seconds #5

Closed gerhard closed 5 years ago

gerhard commented 5 years ago

This started in the context of prometheus/docs#1414, specifically https://github.com/prometheus/docs/pull/1414#issuecomment-524250746

These are all the time metrics that this collector now exposes:

# TYPE erlang_net_ticktime_seconds gauge
# HELP erlang_net_ticktime_seconds Inter-node heartbeat interval in seconds
erlang_net_ticktime_seconds 60
# TYPE erlang_uptime_seconds_total counter
# HELP erlang_uptime_seconds_total Total node uptime
erlang_uptime_seconds_total 2.146
# TYPE rabbitmq_io_read_time_seconds_total counter
# HELP rabbitmq_io_read_time_seconds_total Total I/O read time
rabbitmq_io_read_time_seconds_total 9.0e-6
# TYPE rabbitmq_io_write_time_seconds_total counter
# HELP rabbitmq_io_write_time_seconds_total Total I/O write time
rabbitmq_io_write_time_seconds_total 5.8e-5
# TYPE rabbitmq_io_sync_time_seconds_total counter
# HELP rabbitmq_io_sync_time_seconds_total Total I/O sync time
rabbitmq_io_sync_time_seconds_total 0.0
# TYPE rabbitmq_io_seek_time_seconds_total counter
# HELP rabbitmq_io_seek_time_seconds_total Total I/O seek time
rabbitmq_io_seek_time_seconds_total 0.0
# TYPE rabbitmq_io_open_attempt_time_seconds_total counter
# HELP rabbitmq_io_open_attempt_time_seconds_total Total file open attempts time
rabbitmq_io_open_attempt_time_seconds_total 3.37e-4
gerhard commented 5 years ago

Do the time metrics now look right @brian-brazil?

brian-brazil commented 5 years ago

That looks about right, however erlang_uptime_seconds is a gauge as you care about it's value rather than that it's increasing at 1s/s.