search

rabbitmq / rabbitmq-prometheus

A minimalistic Prometheus exporter of core RabbitMQ metrics
Other
145 stars 109 forks source link

Add test & update Grafana dashboard for Erlang distribution buffer busy limit, a.k.a. zdbbl #51

Closed gerhard closed 4 years ago

gerhard commented 4 years ago

Since none that watched TGIR S01E04 contributed this feature, I will add the missing pieces & back-port to v3.8.x

This is a follow-up to #40 & it closes #39 .

gerhard commented 4 years ago

Merge & back-port to v3.8.x after checks go green.

gerhard commented 4 years ago

Back-ported to v3.8.x via https://github.com/rabbitmq/rabbitmq-prometheus/commit/0612960036d0c0cc29eefe48de224a4db81fc5d4

bhughes23 commented 4 years ago

How can we deploy this fix to a cluster running 3.8.2 without upgrading to 3.8.4?

gerhard commented 4 years ago
  1. Stop RabbitMQ
  2. In the plugins directory (rabbitmq-diagnostics environment | grep plugins_dir) remove prometheus-4.4.0.ez & add prometheus-4.6.0.ez (you will find this inside https://github.com/rabbitmq/rabbitmq-server/releases/download/v3.8.8/rabbitmq-server-generic-unix-3.8.8.tar.xz)
  3. Start RabbitMQ
  4. Repeat for all other RabbitMQ nodes
  5. When done, remember to update your Erlang-Distribution Grafana dashboard to latest (the metric name has changed): https://grafana.com/grafana/dashboards/11352

While the above is possible, I am not sure why you would want to mix & match components from different RabbitMQ versions. We shipped many fixes & added significant new features between v3.8.2 & v3.8.8. All release notes in one place: https://github.com/rabbitmq/rabbitmq-website/tree/live/site/release-notes

What is preventing you from upgrading to latest stable RabbitMQ v3.8.8?

cc @michaelklishin

michaelklishin commented 4 years ago

Such "patch upgrades" of individual plugins void your warranty. We don't test plugins against older patch releases (except for mixed version clusters with the previous patch, where applicable — this plugin is node-local by design).