search

rabbitmq / rabbitmq-recent-history-exchange

RabbitMQ Recent History Exchange
Other
82 stars 21 forks source link

Switch test suite to Common Test #24

Closed michaelklishin closed 8 years ago

michaelklishin commented 8 years ago

Fixes #23.

kjnilsson commented 8 years ago

All fine but one improvement that could be made is that some of the tests use the same queue and exchange name and with a shared broker it may be better to ensure each test has a unique topology to execute against which may reduce the change of cross test interference. I did something like that in here: https://github.com/rabbitmq/rabbitmq-delayed-message-exchange/blob/master/test/plugin_SUITE.erl#L74 where I generate a test_resource_name to use as a base for queue and exchange names in each test.

michaelklishin commented 8 years ago

Done.