search

rabbitmq / rabbitmq-recent-history-exchange

RabbitMQ Recent History Exchange
Other
82 stars 21 forks source link

History size in config file #3

Closed Icarus-xx closed 10 years ago

Icarus-xx commented 12 years ago

As mentioned in the the title, it would be nice to be able to change the history/replay size in the RabbitMQ configuration file.

cmoesel commented 10 years ago

+1. It would be even more useful (in my opinion) if the size could be passed in as an argument when declaring the exchange.

videlalvaro commented 10 years ago

Yes, this would be useful. Still I'll need to see where to keep such information, since the exchanges are usual stateless.

cmoesel commented 10 years ago

I think there are probably a few good examples to look at. For example, the Alternate Exchange extension allows configuration using arguments in order to declare an exchange with an AE. The Consistent Hash Exchange also supports passing in a hash-header argument to use instead of routing keys. I suspect they need to maintain enough state to remember (and act on) those arguments.

videlalvaro commented 10 years ago

Yes, this could be done using declare arguments, or by using a policy

cmoesel commented 10 years ago

That would be awesome. I already have a use case in mind (for a project I am on) where a history of 1 would be perfect.

videlalvaro commented 10 years ago

Have you seen this: https://github.com/simonmacmullen/rabbitmq-lvc-plugin ?

cmoesel commented 10 years ago

Ha. OK. I think I can use that. ;-)

I still think it would be cool to have a configurable value in yours too though! But now I guess I don't have to wait for it... Thanks!

videlalvaro commented 10 years ago

This has been implemented in master. See README