search

rabbitmq / rabbitmq-server

Open source RabbitMQ: core server and tier 1 (built-in) plugins
https://www.rabbitmq.com/
Other
12.16k stars 3.91k forks source link

4.0: remove per-vhost connection limit for protocols other than AMQP 0-9-1 #10282

Open michaelklishin opened 9 months ago

michaelklishin commented 9 months ago

Per virtual host connection limit inevitably requires either

We also have per-node limits which do not require any of the above and use a local counter/connection table.

For 4.0, the team has decided to drop per-vhost support for protocols other than AMQP 0-9-1 (where we see them used), namely protocols like MQTT where very large numbers of concurrent connections is much more common, and that may or may not even have the concept of a virtual host (MQTT does not).

This would allow us to extent per-node connection limits to all of those protocols without paying a hefty performance penalty for newly established connections.

This discussion was initiated by some initial QA/review feedback for https://github.com/rabbitmq/rabbitmq-server/pull/9876.

ikavgo commented 8 months ago

Removed from MQTT here https://github.com/rabbitmq/rabbitmq-server/pull/9876