search

rabbitmq / rabbitmq-server

Open source RabbitMQ: core server and tier 1 (built-in) plugins
https://www.rabbitmq.com/
Other
11.84k stars 3.9k forks source link

make: Better restrict FAST_RUN_BROKER #11558

Closed lhoguin closed 6 days ago

lhoguin commented 1 week ago

Enable by default only when run-broker, run-tls-broker, start-brokers or start-cluster is explicitly used.

Should avoid issues with running the broker in tests.

I will work on some refactoring to ensure we can easily iterate dev run-broker without risking breaking tests.

lhoguin commented 6 days ago

Right, PLUGINS is still around and works as you noted, with spaces. But it's only used when building a proper release in the top-level Makefile. It is used to create a plugins.mk file that contains the PLUGINS variable, and is included in the source-dist. I assume something somewhere makes use of it.

Perhaps we can add support for PLUGINS when FAST_RUN_BROKER=1 as that is a more natural way of specifying plugins than comma lists.

lhoguin commented 6 days ago

I will drop this PR in favor of what I am currently working on. I have managed to make the old method of running the broker about as fast if not faster than FAST_RUN_BROKER when -j8 is used (parallel make). Therefore FAST_RUN_BROKER is no longer necessary. I will push that change in my other PR https://github.com/rabbitmq/rabbitmq-server/pull/11549 and look into honoring PLUGINS there as well.