Open LoisSotoLopez opened 1 week ago
cd deps/rabbitmq_prometheus
gmake tests
on this branch fails for me with
rabbit_prometheus_http_SUITE > per_object_metrics > globally_configure_per_object_metrics_test
#1. {error,
{{assertEqual,
[{module,rabbit_prometheus_http_SUITE},
{line,413},
{expression,
"re : run ( Body , \"^rabbitmq_queue_get_ack_total{\" , [ { capture , none } , multiline ] )"},
{expected,match},
{value,nomatch}]},
[{rabbit_prometheus_http_SUITE,per_object_metrics_test,2,
[{file,"rabbit_prometheus_http_SUITE.erl"},{line,413}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}
rabbit_prometheus_http_SUITE > per_object_endpoint_metrics > endpoint_per_object_metrics
#1. {error,
{{assertEqual,
[{module,rabbit_prometheus_http_SUITE},
{line,413},
{expression,
"re : run ( Body , \"^rabbitmq_queue_get_ack_total{\" , [ { capture , none } , multiline ] )"},
{expected,match},
{value,nomatch}]},
[{rabbit_prometheus_http_SUITE,per_object_metrics_test,2,
[{file,"rabbit_prometheus_http_SUITE.erl"},{line,413}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}
and one more error that can be inspected by opening logs/index.html
after the CT test run.
cd deps/rabbitmq_prometheus gmake tests
on this branch fails for me with
rabbit_prometheus_http_SUITE > per_object_metrics > globally_configure_per_object_metrics_test #1. {error, {{assertEqual, [{module,rabbit_prometheus_http_SUITE}, {line,413}, {expression, "re : run ( Body , \"^rabbitmq_queue_get_ack_total{\" , [ { capture , none } , multiline ] )"}, {expected,match}, {value,nomatch}]}, [{rabbit_prometheus_http_SUITE,per_object_metrics_test,2, [{file,"rabbit_prometheus_http_SUITE.erl"},{line,413}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1302}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1234}]}]}} rabbit_prometheus_http_SUITE > per_object_endpoint_metrics > endpoint_per_object_metrics #1. {error, {{assertEqual, [{module,rabbit_prometheus_http_SUITE}, {line,413}, {expression, "re : run ( Body , \"^rabbitmq_queue_get_ack_total{\" , [ { capture , none } , multiline ] )"}, {expected,match}, {value,nomatch}]}, [{rabbit_prometheus_http_SUITE,per_object_metrics_test,2, [{file,"rabbit_prometheus_http_SUITE.erl"},{line,413}]}, {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]}, {test_server,run_test_case_eval1,6, [{file,"test_server.erl"},{line,1302}]}, {test_server,run_test_case_eval,9, [{file,"test_server.erl"},{line,1234}]}]}}
and one more error that can be inspected by opening
logs/index.html
after the CT test run.
Yep. Should be fixed up right now. Wasn't expecting the core team to look at draft PRs. Won't open them any more if that's the case. :+1:
Proposed Changes
Solves the issue explained at https://github.com/rabbitmq/rabbitmq-server/issues/11217
rabbit_core_metrics
tables, where per queue, per exchange and per queue/exchange metrics will be stored without including a channel ID on the key.rabbit_core_metrics
to populate them onchannel_stats
calls, apart from populating those metrics per channel.rabbit_mgmt
andprometheus_rabbitmq_core
_metrics_collector
s to collect those metrics.rabbit_prometheus_http_SUITE
Types of Changes
Checklist
CONTRIBUTING.md
document