search

rabbitmq / rabbitmq-server

Open source RabbitMQ: core server and tier 1 (built-in) plugins
https://www.rabbitmq.com/
Other
12.31k stars 3.92k forks source link

By @LoisSotoLopez: Exclude policy_repair QQ test on mixed versions #12666

Closed michaelklishin closed 2 weeks ago

michaelklishin commented 2 weeks ago

This is #12665 by @LoisSotoLopez. References #12412 #12640 #12641.

mergify[bot] commented 2 weeks ago

⚠️ The sha of the head commit of this PR conflicts with #12665. Mergify cannot evaluate rules on this PR. ⚠️

mkuratczyk commented 2 weeks ago

If possible, the test condition should not be "if it's a mixed version test" but something specific to 4.0-4.1 upgrade. Once mixed version tests run 4.1-4.2 or anything beyond, it should run without further actions (performing which we are likely to forget)

michaelklishin commented 2 weeks ago

@mkuratczyk you are right but we do not have such a mechanism in CT helpers. And some of our team members have discussed revisiting such excluded tests for 4.1.x specifically, so I think we won't necessarily forget about them.

michaelklishin commented 2 weeks ago

Given that the majority of such excluded tests can be re-enabled when a release series rolls over, so the "old" series "gain" the behavior previous present only in main, I don't think we necessarily need an exclusion mechanism for a specific pair of versions.

There are so many build system-related changes going on that I'd rather not try to introduce it in the next few months.

michaelklishin commented 2 weeks ago

Per discussion on the team: we will have to revisit such checks after every release, because in a (future) 4.1/4.0 combination, this test would pass and can be run in mixed version mode.

In the future we will likely support N-2 upgrades (this is not a promise of delivery but just an idea on the team), in which case we'd need new helpers that detect/exclude specific combinations of release series, e.g. 4.1.x and 3.13.x but not 4.1.x and 4.0.x.