rabbitmq / rabbitmq-server

Open source RabbitMQ: core server and tier 1 (built-in) plugins
https://www.rabbitmq.com/
Other
12.31k stars 3.92k forks source link

feat/get-messages-reversed: updated UI for "Get Messages" in Queue tab #12717

Closed nsklyarov closed 1 week ago

nsklyarov commented 1 week ago

Hello, @michaelklishin!

This PR is related to my previous #12698 where I tried to implement similar functionality, but in a different way.

I would be glad to hear your opinion and feedback on the new implementation.

Proposed Changes

I've updated the #12698 implementation away from using basic.get.

Types of Changes

Checklist

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

michaelklishin commented 1 week ago

@nsklyarov I don't have much to add to #12698: we'd rather deprecate basic.get and eventually remove it than expand its use.

Tweaks the UI for essentially a polling-based feature count for expanded use.

michaelklishin commented 1 week ago

Thank you for taking the time to contribute. Ideally you should start a discussion before spending any time on a pull request

was ignored as well.

Don't waste your time the 3rd time around. And don't bet your farm on basic.get being around in a year or two.