rabbitmq / rabbitmq-server

Open source RabbitMQ: core server and tier 1 (built-in) plugins
https://www.rabbitmq.com/
Other
12.31k stars 3.92k forks source link

CLI tools: disable incoming disterl listeners. #12762

Open lukebakken opened 2 days ago

lukebakken commented 2 days ago

Is your feature request related to a problem? Please describe.

https://github.com/rabbitmq/rabbitmq-server/discussions/11463#discussioncomment-9784037

CLI tools could (should) use RABBITMQ_CTL_ERL_ARGS="-dist_listen false" by default.

Describe the solution you'd like

RABBITMQ_CTL_ERL_ARGS="-dist_listen false"

Describe alternatives you've considered

N/A

Additional context

N/A

michaelklishin commented 2 days ago

@lukebakken I cannot think of a reason not to do it. rabbitmq-diagnostics consume_event_stream and rabbitmq-diagnostics list_* commands are the closest we have to a "two-way communication" and even they do not need a listener.

But we can tweak the RABBITMQ_CTL_ERL_ARGS default and see how well those commands that stream results (continuously or when there's a large number of, say, queues) do.