rabbitmq / rabbitmq-server

Open source RabbitMQ: core server and tier 1 (built-in) plugins
https://www.rabbitmq.com/
Other
12.31k stars 3.92k forks source link

By @gomoripeti: Streams: two additional Prometheus metrics for connections #12765

Closed michaelklishin closed 1 day ago

michaelklishin commented 2 days ago

This is #10275 by @gomoripeti re-submitted so that Actions have access to all the GH secrets.

michaelklishin commented 1 day ago

I have received no objections to this PR from other core team members.

michaelklishin commented 1 day ago

This seems safe to backport to v4.0.x, too. It's a new metric in a node-local plugin.

michaelklishin commented 1 day ago

@gomoripeti backporting to v4.0.x turned out to be more involved. If you would like to contribute a v4.0.x version of this PR, it will be considered, otherwise it will ship next year in 4.1.0.

gomoripeti commented 20 hours ago

thank you. This feature is not super urgent for us so 4.1.0 sounds good. And I take a note of manually backporting to 4.0.x if time permits.