New style config: support stomp.tcp_listen_options.* - Githubissues

rabbitmq / rabbitmq-stomp

RabbitMQ STOMP plugin

https://www.rabbitmq.com/stomp.html

Other

49 stars 28 forks source link

New style config: support stomp.tcp_listen_options.* #130

Closed michaelklishin closed 5 years ago

michaelklishin commented 5 years ago

Proposed Changes

This introduces support for a number of stomp.tcp_listen_options.* settings in the new style config format. They mimic tcp_listen_options.* available for AMQP 0-9-1 and AMQP 1.0 listeners.

Types of Changes

[x] Bugfix (non-breaking change which fixes issue #129)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (correction or otherwise)
[ ] Cosmetics (whitespace, appearance)

Checklist

[x] I have read the CONTRIBUTING.md document
[x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
[x] All tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in related repositories

Further Comments

Closes #129.

[#157922235]

michaelklishin commented 5 years ago

Config file that can be used for QA:

stomp.listeners.tcp.1 = 127.0.0.1:61613
stomp.listeners.tcp.2 = ::1:61613

stomp.tcp_listen_options.backlog = 2048
stomp.tcp_listen_options.recbuf = 8192
stomp.tcp_listen_options.sndbuf = 8192

stomp.tcp_listen_options.keepalive = true
stomp.tcp_listen_options.nodelay   = true

stomp.tcp_listen_options.exit_on_close = true

stomp.tcp_listen_options.send_timeout = 120