search

rabbitmq / rabbitmq-stream-dotnet-client

RabbitMQ client for the stream protocol
https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html
Other
122 stars 41 forks source link

issue-304 - solve problem with memory leak. Added closing connection #306

Closed MikhailTushev closed 1 year ago

MikhailTushev commented 1 year ago

@resolve issue. @Gsantomaggio, @lukebakken, check pls

Gsantomaggio commented 1 year ago

Thank you for the PR @MikhailTushev, We will check it soon

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% :tada:

Comparison is base (129c3e7) 92.82% compared to head (571458b) 92.88%.

:exclamation: Current head 571458b differs from pull request most recent head c276b05. Consider uploading reports for the commit c276b05 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================== + Coverage 92.82% 92.88% +0.06% ========================================== Files 112 112 Lines 9715 9717 +2 Branches 774 774 ========================================== + Hits 9018 9026 +8 + Misses 535 530 -5 + Partials 162 161 -1 ``` | [Files Changed](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq) | Coverage Δ | | |---|---|---| | [RabbitMQ.Stream.Client/RoutingClient.cs](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq#diff-UmFiYml0TVEuU3RyZWFtLkNsaWVudC9Sb3V0aW5nQ2xpZW50LmNz) | `94.25% <100.00%> (+0.13%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/rabbitmq/rabbitmq-stream-dotnet-client/pull/306/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rabbitmq)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MikhailTushev commented 1 year ago

@Gsantomaggio, Hello, Can i merge? how i can make patch version for this changes?

Gsantomaggio commented 1 year ago

Hello, Can i merge?

you can't :)

how i can make patch version for this changes?

you can't :) ! we will do that as soon as we merge the other pending PR(s)

Thank you