Closed Gsantomaggio closed 10 months ago
Attention: 81 lines
in your changes are missing coverage. Please review.
Comparison is base (
a7c9fd6
) 92.83% compared to head (10a3f5c
) 91.87%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@lukebakken Thanks for the help! Lock removed
Part of https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/issues/336
Improve the disconnection message. It is possible to understand if it is a normal disconnection or an unexpected.
Remove the Active Items from the connection pool and use the Publishers and Consumers client list directly to check the pool size
Refactor the Factory Classes. Remove code duplication in case of metadata update and connection closed. See ReliableBase.OnEntityClosed
Handle streamNotAvailable error. In this case the client will try to reconnect the entity
Fix the events attach to the RawConsumer and RawProducer. The events are attached only if the ResponseCode is OK
Detach the events once the entity receives the disconnection or metadata update. In that case, the entity is closed
Introduce ReliableEntityStatus like a state machine to understand the status of Producer and Consumer classes
Add ResourceAvailableReconnectStrategy interface to Handle the retry in case testing in a stream exists. See ReliableBase CheckIfStreamIsAvailable
Change the MetadataHandler to Func<MetaDataUpdate, Task> to be like the other methods
Producer and Consumer classes fail fast during the first initialization. The user is aware of what is happening. The reconnect part occurs only after the first boot.
How to test
execute a script with multiple consumers and producers: I use https://gist.github.com/Gsantomaggio/f6a091076e498d88ecfe827c2b165dad
restart the docker nodes and see if the client will survive to the restart