search

rabbitmq / rabbitmq-stream-dotnet-client

RabbitMQ client for the stream protocol
https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html
Other
122 stars 41 forks source link

Use user defined loopback address if available (#374) #377

Closed CoenraadS closed 6 months ago

CoenraadS commented 6 months ago

When a loopback address is specified, use it directly instead of using localhost. Because DNS resolution on localhost may resolve to IPV6 (::1), although the user may have expected an IPV4 loopback address (127.0.0.1).

Resolved #374 & #375

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.75%. Comparing base (f2904b0) to head (0eed28b). Report is 1 commits behind head on main.

Files Patch % Lines
RabbitMQ.Stream.Client/StreamSystem.cs 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #377 +/- ## ========================================== - Coverage 92.05% 91.75% -0.30% ========================================== Files 118 118 Lines 12102 12123 +21 Branches 936 938 +2 ========================================== - Hits 11140 11124 -16 - Misses 742 778 +36 - Partials 220 221 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CoenraadS commented 6 months ago

Thanks!

@CoenraadS are you able to test this change in your environment, since you can reproduce the issue?

Yes, the documentation sample now works for me.

A test failed in the pipeline: ConsumerShouldReceiveDelivery, but locally it passes for me.

Gsantomaggio commented 6 months ago

A test failed in the pipeline: ConsumerShouldReceiveDelivery, but locally it passes for me.

Yes, sometimes it fails on the CI. I need to check why!

lukebakken commented 6 months ago

@CoenraadS thank you very much!

Gsantomaggio commented 6 months ago

FYI: https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/releases/tag/v1.8.4