search

rabbitmq / rabbitmq-stream-dotnet-client

RabbitMQ client for the stream protocol
https://rabbitmq.github.io/rabbitmq-stream-dotnet-client/stable/htmlsingle/index.html
Other
122 stars 41 forks source link

Review Size property #61

Closed Gsantomaggio closed 2 years ago

Gsantomaggio commented 2 years ago

At the moment we expose the Size property with also the AMQP10 header size. This could be misleading for the user, we have two ways:

https://github.com/rabbitmq/rabbitmq-stream-dotnet-client/blob/main/RabbitMQ.Stream.Client/AMQP/Data.cs#L24

Any Idea?

Gsantomaggio commented 2 years ago

This is correct in that way. If you want to know the total size it is correct to have also the header information