search

rabbitmq / rabbitmq-stream-go-client

A client library for RabbitMQ streams
MIT License
170 stars 20 forks source link

Heartbeats #239

Closed ablease closed 4 months ago

ablease commented 1 year ago

@Zerpet I put in a basic graceful close mechanism for the Heartbeat done channel. I might still be susceptible to a race condition. The test passes without panicking at least!

I'll make another test case to call the locator operation for sending a heartbeat shortly (to pass the failing static check)

I had tried to incorporate the gleak leak detector. I see you tried as well, but I couldnt not get it to fail? Let me know what you think about having a gleak test.

Zerpet commented 4 months ago

We have paused this work. Closing this PR. We have the branch in case we resume the effort in the future.