rabbitmq / rabbitmq-stream-rust-client

A client library for RabbitMQ streams
Other
152 stars 14 forks source link

Filtering supported #225

Closed JiaYingZhang closed 3 weeks ago

JiaYingZhang commented 1 month ago

Filtering supported

  1. add exchange_command_versions command and check command version;
  2. add version 2 encoder and decoder;
  3. Implemented publish command version2,supporting the filtering feature;
  4. Implemented producer and consumer filtering feature(like java client or python client).
Gsantomaggio commented 1 month ago

Thank you for the PR

Gsantomaggio commented 1 month ago

cc @wolf4ood

DanielePalaia commented 4 weeks ago

Thank you very much for your contribution @JiaYingZhang

It looks good to me. If you can also add an example inside the example folder. Something similar on what you already did in the integration test for producer and consumer

JiaYingZhang commented 4 weeks ago

@DanielePalaia I will add the remaining parts as you suggested.

JiaYingZhang commented 4 weeks ago

@DanielePalaia update for your suggest

  1. consumer predicate type update to Optional and default set None
  2. add filtering example
  3. add consumer test for match_unfiltered set to true

thank you

DanielePalaia commented 3 weeks ago

For me it is good to merge. There maybe a few improvements on the example to do but we can do it when we will create the tutorials for this functionality. The action is failing for a rate limit issue on codecov but tests are passing. @wolf4ood for final approval/comments