search

rabbitmq / rabbitmq-web-mqtt

Provides support for MQTT over WebSockets
Other
55 stars 16 forks source link

Move to common_tests #13

Closed hairyhum closed 8 years ago

hairyhum commented 8 years ago

Fixes #12

dumbbell commented 8 years ago

Please move the test source files to test (instead of test/src).

Also, you should use a shorter name for the testsuite; eg. something like system_SUITE if the testsuite is doing system integration tests. There is no need to prefix the module with rabbit_web_mqtt_ because there can't be namespace conflict. And it's easier to type make ct-system than make ct-rabbit_web_mqtt.

michaelklishin commented 8 years ago

Some of our test suites use "old" suite names, though. So I don't think it's a deal breaker.

dumbbell commented 8 years ago

Not a deal breaker, but it makes it consistent with other converted projects.

dumbbell commented 8 years ago

You need to add rabbit to the TEST_DEPS before including rabbitmq-components.mk. GNU Make will complain about duplicated rules, but that's ok. Once all projects are moved, I will clean rabbitmq-components.mk.

Here is an example from the federation plugin:

PROJECT = rabbitmq_federation

DEPS = amqp_client
TEST_DEPS += rabbit