search

rabbitmq / rabbitmq-web-mqtt

Provides support for MQTT over WebSockets
Other
55 stars 16 forks source link

Send will when client connection stops #52

Closed karenbajador closed 5 years ago

karenbajador commented 5 years ago

This is a fix to issues raised in the following threads: https://github.com/rabbitmq/rabbitmq-web-mqtt/issues/23 https://groups.google.com/forum/#!searchin/rabbitmq-users/last$20will%7Csort:date/rabbitmq-users/Jg88NdgcNPY/1w7LzK10CQAJ

The change is committed so that behaviour will be similar to the rabbitmq-mqtt plugin wherein the lastwill message is dispatched by broker when the mqtt client is killed or died ungracefully.

pivotal-issuemaster commented 5 years ago

@karenbajador Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented 5 years ago

@karenbajador Thank you for signing the Contributor License Agreement!

michaelklishin commented 5 years ago

Thank you. This looks good at first glance but we'd need to add an integration test before merging (our team will take care of that).

karenbajador commented 5 years ago

Thank you. This looks good at first glance but we'd need to add an integration test before merging (our team will take care of that).

Thank you Michael. Looking forward to the fix. Cheers!

michaelklishin commented 5 years ago

I can confirm that the LWT message is sent with this patch but integration tests turned out to be not entirely trivial. On the positive side this PR lead to some testing infrastructure improvements in this plugin 👍

michaelklishin commented 5 years ago

Backported to v3.7.x.

michaelklishin commented 5 years ago

Available in 3.7.10-alpha.26. @karenbajador would you be interested in giving that build a try? We will produce a new RC very soon but it should only have one more unrelated change.

karenbajador commented 5 years ago

Thanks @michaelklishin . That is awesome work. We will give the build a go.

michaelklishin commented 5 years ago

Doh, the link is already dead because a more recent 3.7.10 alpha build was published. Please grab the most recent 3.7.10-alpha from this Bintray repo.

karenbajador commented 5 years ago

This build looks good. Looking forward to the release. Thanks.

michaelklishin commented 5 years ago

3.7.10 is out.

karenbajador commented 5 years ago

Thanks @michaelklishin. Will the docker image be released soon as well?

michaelklishin commented 5 years ago

The Docker image is not maintained by our team. As far as I know, they are blocked on how they provision Erlang.

karenbajador commented 5 years ago

Thanks for the update!