search

rabbitmq / rabbitmq-web-stomp

Provides support for STOMP over WebSockets
Other
89 stars 26 forks source link

Upgrade to latest Cowboy #13

Closed michaelklishin closed 9 years ago

michaelklishin commented 9 years ago

See https://github.com/rabbitmq/rabbitmq-server/issues/170.

lemenkov commented 9 years ago

Sorry for the noise - just subscribing on this.

digipigeon commented 9 years ago

+1

sega-yarkin commented 9 years ago

+1

michaelklishin commented 9 years ago

We have started working on this this week.

essen commented 9 years ago

Yep, working on it as we speak. :-)

essen commented 9 years ago

OK stopping for today, will finish on Monday. Small recap for me to remember when I get back to it:

Also need to update the public umbrella repo to add the two new wrappers, got it done on my local copy but it's simple enough that I can push that on Monday. I will also need to update the git URLs of everything to point to the right repositories.

Enjoy. :-)

michaelklishin commented 9 years ago

@essen we don't need to fork Ranch, Cowlib, etc but pinning them to the most recent stable release tag is a good idea.

lemenkov commented 9 years ago

@michaelklishin agree with that. Also relying on tags is much more easier for package maintainers.

essen commented 9 years ago

All PRs are open, and also pushed directly on master for ranch-wrapper and cowlib-wrapper (hoping there's no issue with that considering the repos were empty to begin with).

michaelklishin commented 9 years ago

Done in master. Good job, @essen!