Allow configuring Cowboy behavior

rabbitmq / rabbitmq-web-stomp

Provides support for STOMP over WebSockets

Other

89 stars 26 forks source link

Allow configuring Cowboy behavior #22

Closed essen closed 9 years ago

essen commented 9 years ago

See #21. Should be a small change to rabbit_ws_sockjs. Not working today so will fill in more details later.

essen commented 9 years ago

Also related to #2.

Should we just add TCP options to the environment like we do in rabbitmq-server?

michaelklishin commented 9 years ago

@essen sounds good.

essen commented 9 years ago

Pushed https://github.com/rabbitmq/rabbitmq-web-stomp/tree/rabbitmq-web-stomp-22

A few remarks/questions:

I updated the port in the code, it didn't look quite right compared to the port in the .app file and the docs, hope it's okay to do it as part of these changes
Do you want me to add tests? I'm not sure what's the best way to test that kind of change but it's definitely possible (I can get inspiration from Cowboy tests I'm sure)
Do we want these options documented on the website?

michaelklishin commented 9 years ago

@essen we do want these documented. Updated fallback port is OK, given that we refer to 15674 everywhere).

As for the tests, if you have an idea about adding some very basic tests (maybe something that asserts on application keys without even starting a listener), go for it. But it's one of those things that are a pain to test and pretty much never change.

essen commented 9 years ago

Pushed https://github.com/rabbitmq/rabbitmq-website/tree/rabbitmq-web-stomp-22 with the doc changes.

Tests... it's not trivial, so I will leave it at that for now. I want to get something up for most of these tickets first.

michaelklishin commented 9 years ago

Fixed in master.